-
Notifications
You must be signed in to change notification settings - Fork 11
map pretalx code to ticket property #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kunsi
wants to merge
1
commit into
crs-tools:master
Choose a base branch
from
Kunsi:kunsi-fahrplan-code
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich hatte festgestellt das der code eigentlich eher als Attribut aufs Event gehört, und nicht als eigenes element... sprich das müssen wir hier noch so anpassen das folgendes XML importiert werden kann:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was soll der Code denn am Ende sein, und wo ist der Mehrwert ggü der GUID?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er löst die Integer ID als kurze ID ab – gegenüber der GUID hat es keine Mehrwehr, abgesehen das er kürzer ist.
Uns haben die Designer z.B. dieses mal die Intros mit Code anstatt Interger IDs als Dateinamen zugeliefert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay.
Dann müsste man eigentlich Fahrplan.ID um-mappen, aber da ist ja nun vermutlich beides parallel vorhanden, und der eine nutzt das und der andere das... naja irgendwer wird schon wissen wofür das gut sein soll.
Hast du schon eine Umsetzung für "Attribut statt Element", oder brauchts da noch weitere Anpassungen, wo ich ggf. noch unterstützen kann?