CI, JLCPCB part numbers, and README improvements#1
Open
flaviut wants to merge 6 commits intocrteensy:mainfrom
Open
CI, JLCPCB part numbers, and README improvements#1flaviut wants to merge 6 commits intocrteensy:mainfrom
flaviut wants to merge 6 commits intocrteensy:mainfrom
Conversation
It confuses JLCPCB assembly
Owner
|
Sorry for being a bit late here. I'm currently on vacation and will take a close look when I'm back |
Author
|
take your time and enjoy your vacation :) maybe by the time you get back, I'll have received boards to test if I messed anything up. |
Author
|
I've had JLCPCB produce and deliver the boards: My scope is only 100MHz and my crystal only 12MHz, but everything checks out: I ended up going with this can instead of the one in the BOM--not that that's relevant to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This is a bit of a big PR, and I'd be happy to split it up (or you could cherry-pick as appropriate) as you'd like.