Removes dependency on active_support#1
Open
heythisisnate wants to merge 1 commit intocrushlovely:masterfrom
Open
Removes dependency on active_support#1heythisisnate wants to merge 1 commit intocrushlovely:masterfrom
heythisisnate wants to merge 1 commit intocrushlovely:masterfrom
Conversation
updates MaxMind default url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using
cattr_accessorandclass_inheritable_attributewhich are part of active_support. I removed this dependency by just using regular ruby instead. The motivation for this is becauseclass_inheritable_attributehas been removed from Rails 3.2, and there's no good reason to have a dependency on Rails anyway.I also added a Gemfile, organized the gemspec a bit and removed a couple of other old dependencies that aren't necessary anymore.
Also, the default URL for MaxMind changed, so I updated that, too.
I have gem version 1.1.0 ready to go ... can you give me permission to push the gem? Just do