fix: improve compatibility for Python 3.9+ with type hint unions#1
Open
Elyter wants to merge 2 commits intocruzanstx:mainfrom
Open
fix: improve compatibility for Python 3.9+ with type hint unions#1Elyter wants to merge 2 commits intocruzanstx:mainfrom
Elyter wants to merge 2 commits intocruzanstx:mainfrom
Conversation
Elyter
changed the title
Elyter
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Although this project specifies Python 3.10+ as a requirement, many users (especially on macOS or older Linux distros) still have
python3defaulting to Python 3.9 out of the box. Running the CLI directly on these systems currently leads to an immediate crash:TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'This PR adds a tiny, zero-dependency one-liner (
from __future__ import annotations) to defer the evaluation of type annotations. This simple addition makes the moderndict | Nonesyntax seamlessly backward-compatible down to Python 3.7.Motivation
This ensures a much smoother first-time experience for users running older Python versions, without needing any code refactoring constraints for the repository!