Skip to content

refactor(crypto-keys): Extract foundation crypto keys#1162

Merged
leumor merged 1 commit intodevelopfrom
feature/pr-71-foundation-crypto-keys
Mar 23, 2026
Merged

refactor(crypto-keys): Extract foundation crypto keys#1162
leumor merged 1 commit intodevelopfrom
feature/pr-71-foundation-crypto-keys

Conversation

@leumor
Copy link
Collaborator

@leumor leumor commented Mar 23, 2026

Summary

  • add the new internal leaf module :foundation-crypto-keys and wire it into the root build
  • move the full main-source network.crypta.crypt and network.crypta.keys boundary into that leaf without changing package names
  • move the residual generic helper blockers into :foundation-support, and move BucketTools plus PrependLengthOutputStream into :foundation-crypto-keys
  • keep the extracted persistence helpers working by fixing the reflective BucketTools bridge for inherited FileBucket.split(int) lookup and pooled RAF restore
  • add focused regression tests for persistent file-bucket splitting and pooled RAF restore via BucketTools

Validation

./gradlew :foundation-support:compileJava :foundation-crypto-keys:compileJava :compileJava
./gradlew test --tests 'network.crypta.support.LoaderTest' --tests 'network.crypta.support.SimpleReadOnlyArrayBucketTest' --tests 'network.crypta.support.StringValidityCheckerTest' --tests 'network.crypta.support.io.FilenameGeneratorTest' --tests 'network.crypta.support.io.FilenameSanitizerTest' --tests 'network.crypta.support.io.BucketToolsTest' --tests 'network.crypta.support.io.PrependLengthOutputStreamTest' --tests 'network.crypta.support.io.PooledFileRandomAccessBufferTest' --tests 'network.crypta.keys.*' --tests 'network.crypta.crypt.*'

Notes

  • package names and behavior are unchanged; this is a physical ownership/build-boundary extraction
  • tests remain in the root project for this PR

Move the crypt and keys main-source boundary into a new internal leaf module and re-home the remaining support blockers needed for the extraction.

Keep the new BucketTools bridge compatible with inherited file-bucket split methods and pooled RAF restore, and add focused regression tests for those reflective paths.
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
76.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@leumor leumor merged commit 8b2d31c into develop Mar 23, 2026
7 of 8 checks passed
@leumor leumor deleted the feature/pr-71-foundation-crypto-keys branch March 23, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant