refactor(foundation-support): Move wire prep helpers#1165
Merged
Conversation
Move the generic wire-adjacent helper set into foundation-support. Add SerializationLimits for shared support-owned bounds, keep Serializer constants as compatibility aliases, remove the comparator dependency on NodeStats, and claim the moved outputs in selective leaf ownership metadata. Verified with foundation-support/root compilation and the focused helper and io.comm tests for the moved surface.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:foundation-supportwithout changing package namesSerializationLimitsand keepSerializersize constants as compatibility aliases soBufferno longer depends onNewPacketFormatNodeStatsdependency fromInetAddressIpv6FirstComparatorand claim the moved outputs infoundation-supportselective ownership metadataThis is the PR-74 prep change for the future
:interop-wireextraction. It does not create:interop-wireyet and does not change protocol semantics.How to test
./gradlew verifySelectiveLeafOwnershipMetadata./gradlew :foundation-support:compileJava./gradlew compileJava./gradlew test --tests "network.crypta.support.BitArrayTest" --tests "network.crypta.support.BufferTest" --tests "network.crypta.support.ByteBufferInputStreamTest" --tests "network.crypta.support.ShortBufferTest" --tests "network.crypta.support.SentTimeCacheTest" --tests "network.crypta.support.SparseBitmapTest" --tests "network.crypta.io.AddressIdentifierTest" --tests "network.crypta.support.transport.ip.HostnameUtilTest" --tests "network.crypta.support.transport.ip.IPUtilTest" --tests "network.crypta.support.io.InetAddressIpv6FirstComparatorTest" --tests "network.crypta.io.comm.MessageTest" --tests "network.crypta.io.comm.MessageTypeTest" --tests "network.crypta.io.comm.PeerTest"