refactor(interop-wire): Extract wire message nucleus#1166
Merged
Conversation
Add the new :interop-wire leaf and move the narrow message/schema/version/probe subset into it. Introduce MessageSource as the minimal seam between leaf-owned Message types and root-owned PeerContext, then update the affected root handlers to cast only where transport access is still required. Also wire the new leaf into root build aggregation and add selective ownership metadata for non-clean build safety.
Update README and the relevant repository skills to describe the current multi-project layout after the support, store, crypto, and wire extractions. This refresh covers module ownership, root-vs-leaf boundaries, compile guidance, packaging expectations, and the moved AEAD source paths so future agent runs and contributor docs point at the right locations.
Delete the root copies of the message/schema/version/probe files that now belong to :interop-wire. This completes the extraction by leaving the root project with only the transport-facing comm classes and the small handler adaptations that still depend on PeerContext transport methods.
|
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa2100bfb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:interop-wireleaf, wire it into the root build, and add selective ownership metadata for non-clean builds:interop-wire, including the leaf-safenetwork.crypta.io.commmessage types,network.crypta.node.Version, probe enums, andnetwork.crypta.support.Serializernetwork.crypta.io.comm.MessageSource, makePeerContextextend it, and update the few root call sites that still need transport accessREADME.mdand the relevant.agents/skills/*guidance so the documented module layout matches the current extracted-leaf architectureNotes
interop-wire/build.gradle.ktsincludes generated-source wiring fornetwork.crypta.node.Version, because the shared Java conventions exclude that template from direct compilation and the new leaf still needs to produce the generated classHow to test