Features/pip packages#523
Merged
stepansnigirev merged 6 commits intocryptoadvance:masterfrom Oct 17, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uploads PIP-Packages to the github-release-page. It also creates sha256-hashes for the tar-package.
In combination with #496 this should make the pip-installation as a workaround for non working binaries much more attractive from a security point of view.
Testing for this is quite difficult but if this fails, at least the twine-upload is happening before that and would not fail.
So there shouldn't be anything existing in danger with this.
The version-number pattern has been adapted to semver as well so that we can at least test this with prereleases.