Move navbar to the bottom of the page & share it across all pages #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
proof-of-reality
commented
Feb 14, 2024
proof-of-reality
commented
Since the toolbar is now available in all pages it's easier to just navigate to the page you want and/or open new tabs using <C-Click>
gui/templates/base.html
Outdated
| <span class="w3-padding-small w3-right" style="max-height:30px;"> | ||
| <a class="w3-bar-item w3-hover w3-text-white" title="Last Update" id="refresh_stats" style="padding:8px 0px"></a> | ||
| <a class="w3-bar-item w3-hover w3-btn" title="Toggle Theme" id="themeToggler" style="padding:8px">{% if request.COOKIES.darkmode == 'true' %}☀️{%else%}🌙{% endif %}</a> | ||
| <a class="w3-bar-item w3-hover w3-text-red" title="Logout" href="{% url 'logout' %}" style="padding:8px">⏻</a> |
Owner
There was a problem hiding this comment.
The logout button is not rendering like your screenshots, not sure if it made it after the git push.
I also noticed we have an issue with the logout function in Django >= 5.0 as it no longer allows a GET request to the logout URL and must use POST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.