ML-DSA: F*: add specs and proofs to the trait layer#1279
Draft
ML-DSA: F*: add specs and proofs to the trait layer#1279
Conversation
jschneider-bensch
added
the
waiting-on-author
The assume was particularly bad because this inserts `False` in VCs in every pre- and post-conditions, making every proof trivial.
…xceeds`, `decompose`
…ns for `serialize_vector`
…ns for `serialize`
Added some pre-conditions in the definitions of post-conditions. It broke a proof in the [avx2] implementation
clementblaudeau
force-pushed
the
libcrux-ml-dsa-prove-trait-operations
branch
from
b73f055 to
36a8c7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libcrux's ML-DSA delegates lower-level operations to
simd::trait::Operations, a trait that defines parallel operations that can be performed by various "backends":avx2on Intel CPUs, orportableotherwise.In this repo, the proofs are mostly about functions below that abstraction.
The
Operationstrait lacks specifications, and itsportableandavx2implementations lacks glue proofs.Some of the higher-level operations lack proofs: they rely on this
Operationstrait, that are often lacking specifications.This PR aims at propagating specifications and proofs from the lower-level concrete (e.g. avx2 or portable) operations to the
Operationstrait, and then to the higher-level operations.This PR (mostly by @clementblaudeau) is a start. This PR:
This work is very partial, more specifications and proofs need to be added.