Fix hax compilation of crates relying on classification traits#1312
Merged
jschneider-bensch merged 3 commits intomainfrom Feb 24, 2026
Merged
Fix hax compilation of crates relying on classification traits#1312jschneider-bensch merged 3 commits intomainfrom
jschneider-bensch merged 3 commits intomainfrom
Conversation
…oid breaking compilation under 'hax' cfg.
maximebuyse
force-pushed
the
fix-hax-extraction-cfg
branch
from
0a7e61f to
ed13c30
Compare
franziskuskiefer
approved these changes
Feb 5, 2026
Member
franziskuskiefer
left a comment
franziskuskiefer
left a comment
There was a problem hiding this comment.
lgtm. @jschneider-bensch do we have other crates where we should fix this? Also, should we add a dummy crate (or get #1259 in) to have a test in the repo to make sure we don't break this again?
Collaborator
cfm
added a commit
to cfm/hpke-rs
that referenced
this pull request
Feb 20, 2026
cfm
added a commit
to cfm/securedrop-protocol
that referenced
this pull request
Feb 23, 2026
cfm
added a commit
to cfm/securedrop-protocol
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is to use
hax_lib::excludeinstead ofcfg(not(hax))to exclude the unsupported items from hax extraction, without breaking compilation under thehaxcfg.This PR replaces #1263
[skip changelog]