Improve-unit-handling-hpwh #515
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto develop-units-hpwh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Significant overhaul of unit-handling in HPWHsim. Physical quantities are transmitted to/from HPWHsim as objects with a units property. A parameter such as temperature can be specified directly in a function call to HPWHsim using the form {20., Units::C}. A returned quantity is converted to a double of appropriate dimensions using a form such as hw_pHPWH->getTankHeatContent()(Units::kWh).
-Several cse regression tests failed as a result of slight differences in physical constants.