Accumulator #566
Closed
Accumulator #566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@chipbarnaby which phase did you decide to use when updating the accumulators? This is still in DRAFT. Let me know when it's ready to merge. |
Contributor
Author
|
Initial accumulator implementation parallels METER calc sequence. It has not yet be tested on tricky cases where expression evaluation order might trip things up. Hence, the PR is draft. I plan to add nasty test cases and that might alter the implementation and/or the design. |
Contributor
|
@chipbarnaby, I wonder if we want to also include:
That way you can see when a peak value occurs. |
Contributor
Author
|
Good idea. I'll add that unless it proves unworkable for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Accumulator placeholder