Eliminate unused types from cndtypes.def; rcdef cleanup; CMake build improvements #587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
reviewed
Nov 13, 2025
src/CNFIELDS.DEF
Outdated
| POWER FLOAT LMNONE UNPOWER // Btuh | ||
| POWER_NZ FLOAT LMNZ UNPOWER // Many "POWER" fields actually | ||
| POWER_GZ FLOAT LMGZ UNPOWER // should be "ENERGY". | ||
| POWER_GZ FLOAT LMGZ UNPOWER // should be "ENERGY".0756 |
Contributor
Author
There was a problem hiding this comment.
No. However, I am mystified as to where the .0756 came from. I grepped "everywhere" for those chars and did not find them. ??
chipbarnaby
changed the title
chipbarnaby
changed the title
nealkruis
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code out cndtype.def definitions of internal-only data types (e.g. date/time structures and pointers). These types are unprobable. In cnrecs.def, use *declares in place of custom data types.
In addition, fixed a long-standing rcdef bug the prevented using *declare as the last item in a record. Replaced some rcdef input file managment globals with a class. Improved output. Added file rcdef_success.txt that is created if-and-only-if rcdef succeeds.
cse/src/CMakeLists.txt -- reworked to use rcdef_success.txt. Fixes double run problem.
No results changes. No documentation changes.