Skip to content

Fix CHDHW fan power bug #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nealkruis merged 1 commit into from
Dec 30, 2025
Merged

Fix CHDHW fan power bug #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/cnloads.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6461,13 +6461,15 @@ RC RSYS::rs_FinalizeSh()
else if (rs_IsCHDHW())
{ // cycling
// pump power

// CHDHW model: air flow / fan power derived from output
rs_outSenTot = rs_runF * rs_capHt;
float avf;
float fanPwr;
float avf; // AVF, cfm
float fanPwr; // fan power, W
rs_pCHDHW->hvt_BlowerAVFandPower(rs_outSenTot, avf, fanPwr);
// if (rs_runF < 1.) cycle?

rs_outFan = rs_runF * fanPwr * Top.tp_subhrDur * BtuperWh;
rs_outFan = rs_runF * fanPwr * BtuperWh; // fan heat, Btuh
rs_outSen = max(0., rs_outSenTot - rs_outFan); // net -> gross
runFFan = rs_runF;

Expand Down
3 changes: 2 additions & 1 deletion src/dhwcalc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2416,7 +2416,8 @@ void DHWSYS::ws_AccumCHDHWFlowSh(
float vol, // volume during current subhour, gal
float tR) // return temperature, F
// coupling of heating load to DHWSYS is subhour lagged
// RSYS determines water volume needed for heating given available
// Note a DHWSYS can serve multiple RSYSs.
// each RSYS determines water volume needed for heating given available
// water temp. That vol is accumulated here and added to draws
// for next subhour.
{
Expand Down
Loading