Skip to content

Remove the hardcoded URL added in df672d2 #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
5Ub-Z3r0 wants to merge 6 commits into from
Closed

Remove the hardcoded URL added in df672d2 #100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
91b1e57
pin ubuntu version to avoid python setup failure
5Ub-Z3r0 Jul 17, 2025
98c6d95
Merge branch 'csingley:master' into master
5Ub-Z3r0 Jul 17, 2025
dc1ac57
Remove duplicate currency in EquitySummaryByReportDateInBase
5Ub-Z3r0 Jul 17, 2025
e238d37
Update endpoints per https://www.ibkrguides.com/complianceportal/comp…
5Ub-Z3r0 Jul 17, 2025
5b57356
Remove the hardcoded URL added in df672d2
5Ub-Z3r0 Jul 17, 2025
79e4954
Update test_client.py
5Ub-Z3r0 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/commit-ibflex.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on: [push, pull_request]
jobs:
build:

runs-on: ubuntu-latest
runs-on: ubuntu-22.04
strategy:
matrix:
python-version: [3.7, 3.8]
Expand Down
1 change: 0 additions & 1 deletion ibflex/Types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,6 @@ class EquitySummaryByReportDateInBase(FlexElement):
physDel: Optional[decimal.Decimal] = None
physDelLong: Optional[decimal.Decimal] = None
physDelShort: Optional[decimal.Decimal] = None
currency: Optional[str] = None
insuredBankDepositRedemptionCashComponentLong: Optional[decimal.Decimal] = None
insuredBankDepositRedemptionCashComponentShort: Optional[decimal.Decimal] = None
incentiveCouponAccrualsLong: Optional[decimal.Decimal] = None
Expand Down
8 changes: 3 additions & 5 deletions ibflex/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@
###############################################################################
# SERVICE LOCATIONS
###############################################################################
FLEX_URL = 'https://gdcdyn.interactivebrokers.com/Universal/servlet/'
REQUEST_URL = FLEX_URL + 'FlexStatementService.SendRequest'
STMT_URL = FLEX_URL + 'FlexStatementService.GetStatement'
FLEX_URL = 'https://ndcdyn.interactivebrokers.com/AccountManagement/FlexWebService/'
REQUEST_URL = FLEX_URL + 'SendRequest'
STMT_URL = FLEX_URL + 'GetStatement'


###############################################################################
Expand Down Expand Up @@ -136,8 +136,6 @@ def request_statement(
"""First part of the 2-step download process.
"""
url = url or REQUEST_URL
### AKE FIX
url = 'https://ndcdyn.interactivebrokers.com/portal.flexweb/api/v1/flexQuery'
response = submit_request(url, token, query=query_id)
stmt_access = parse_stmt_response(response)
if isinstance(stmt_access, StatementError):
Expand Down
1 change: 0 additions & 1 deletion tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ def test_request_statement(self, mock_requests_get):
datetime.timedelta(hours=-4)))
)
self.assertEqual(output.ReferenceCode, "1234567890")
self.assertEqual(output.Url, client.STMT_URL)


@patch("requests.get", side_effect=mock_response)
Expand Down
Loading