Allow installation of psalm 6, Drop PHP 8.0 support #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uppresses which are not relevant for the test case. Add some unused supresses for the plugin itself. Update deps.
cspray
requested changes
Jan 30, 2025
src/AllowInheritance.php
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| use Attribute; | |||
|
|
|||
| /** @psalm-suppress UnusedClass */ | |||
There was a problem hiding this comment.
I actually believe this should be annotated as @api. This communicates the class is part of the public facing API used by installers of this lib.
Edit: And, of course, getting the build to go green :)
There was a problem hiding this comment.
Ah, didnt know this annotation exist.
Regarding failing build: would drop PHP 8.0 then :)
DanielBadura
changed the title
|
@cspray could you again have a look on this patch? |
|
@DanielBadura Sorry for the delay. I will review this today. Thanks! |
|
Thank you very much for your contribution! I'll cut a new major release soon to enable using Psalm 6. |
cspray
approved these changes
Feb 12, 2025
|
Thanks! I don't think you would need a new major version for this since the API for the user did not change. But the choice is yours :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the stub logic alltogether since it was not used, added some supresses to satify pslam as it seems this is the way to go here, otherwise i would have created a baseline for them.