Skip to content

use su -s instead of -c for getting interactive shell #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rhjdvsgsgks wants to merge 1 commit into
base: v8
Choose a base branch
from
Open

use su -s instead of -c for getting interactive shell #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions shell/tsu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,10 @@ unset LD_PRELOAD

## Build the environment
[[ -z "$_TSU_DEBUG" ]] || set +x
ENV_BUILT=""
ENV_BUILT=()

for key in "${!EXP_ENV[@]}"; do
ENV_BUILT="$ENV_BUILT $key=${EXP_ENV[$key]} "
ENV_BUILT+=("$key=${EXP_ENV[$key]}")
done
[[ -z "$_TSU_DEBUG" ]] || set -x

Expand Down Expand Up @@ -315,12 +315,13 @@ else
# Let's use the system toybox/toolbox for now
if [[ -n "$ENVIRONMENT_PRESERVE" ]]; then
su_args+=("--preserve-environment")
Copy link

@yujincheng08 yujincheng08 May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless when you use -p

su_cmdline="PATH=$ANDROID_SYSPATHS:$PATH $ENV_BUILT $STARTUP_SCRIPT "
path_for_system_env="PATH=$ANDROID_SYSPATHS:$PATH"
else
su_cmdline="PATH=$ANDROID_SYSPATHS env -i $ENV_BUILT $STARTUP_SCRIPT"
path_for_system_env="PATH=$ANDROID_SYSPATHS"
env_cmd="-i"
fi
su_args+=("-c")
exec "${su_args[@]}" "${su_cmdline}"
su_args+=("-ps")
exec env "$path_for_system_env" env "$env_cmd" "${ENV_BUILT[@]}" "${su_args[@]}" "$STARTUP_SCRIPT"
fi
done
fi
Expand Down