Misleading Curl error output on Windows, incorrect Hash generation for package#11
Open
IgalOre wants to merge 11 commits intocthorne66:masterfrom
Open
Misleading Curl error output on Windows, incorrect Hash generation for package#11IgalOre wants to merge 11 commits intocthorne66:masterfrom
IgalOre wants to merge 11 commits intocthorne66:masterfrom
Conversation
update grunt library to 1.0.1
cthorne66
reviewed
Aug 9, 2017
|
|
||
| artifactStream.on('data', function(chunk) { | ||
|
|
||
| var binaryChunk = chunk.toString('binary'); |
Owner
There was a problem hiding this comment.
I'm not so sure about removing this line. It seems to be working for others (I'm assuming by lack of other bugs). I know the unit tests have run successfully. Would you be willing to test out on a linux machine as well to ensure we don't introduce a different issue?
Thank you
Author
There was a problem hiding this comment.
Alternatively this binary conversion could be activated not on Windows only. Just query same variable if on Windows platform and then activate it if not Windows.
What do you think about that ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
First of all thank you for excellent package, saved and saving a lot of time.
Since all our build environment are Windows setups, i had encountered some bogus error message when package where running. After debugging find out that there setup for deviating output into "/dev/stderr", but unfortunately it does not exit on Windows machines. I added verification if running on Windows based machines and not adding that options.
Secondly after retrieving package throw Maven build, got message that generated Hash do not corresponds to one generated based on file. While debugging figured out that in on data event there toString('binary') conversion while, at least for my setup it were not needed, therefore I had removed it.
Could you please consider merging those changes, and releasing to NPMJS new version ?
Thank you in advance