Skip to content

Conversation

@ysfaran
Copy link
Contributor

@ysfaran ysfaran commented Jul 14, 2025

This would resolve the second part of #20.

The PR adds a new field previousAttempts in case the same TestCase has multiple test results, which primarily happens if a test was flaky.

As suggested in #20 I just added minimal information to the attemps:

export interface CtrfTestAttempt {
  status: CtrfTestState
  duration: number
  message?: string
  trace?: string
  snippet?: string
}

I also added a simple test.

Let me know what you think 🙂

@Ma11hewThomas
Copy link
Collaborator

Thanks for this, @ysfaran.

I've been assessing how to include retry information and decided that your suggestion for the property name to be retryAttempts is a better fit than' previousAttempts'.

Otherwise, I'm happy with the change.

@ysfaran ysfaran force-pushed the feat/previous-attempts branch from 2b21de3 to 9efcffb Compare July 22, 2025 12:22
@ysfaran
Copy link
Contributor Author

ysfaran commented Jul 22, 2025

@Ma11hewThomas great!

I updated the commit by using the word retry instead of previous for the attempts.

@Ma11hewThomas Ma11hewThomas self-requested a review July 22, 2025 19:41
@Ma11hewThomas Ma11hewThomas merged commit 3f58e46 into ctrf-io:main Jul 22, 2025
1 check passed
@ysfaran ysfaran deleted the feat/previous-attempts branch July 23, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants