Move test data out of package space and remove tests of schema files#282
Merged
pbchase merged 2 commits intoctsit:developfrom Sep 29, 2025
Merged
Move test data out of package space and remove tests of schema files#282pbchase merged 2 commits intoctsit:developfrom
pbchase merged 2 commits intoctsit:developfrom
Conversation
Move test data from package scope to test scope. Remove 9 man pages for test data that movwed to test scope. Remove tests that were only testing schema files. Remove helpers used only by the removed tests. Fix tests that needed the rescoped test data.
There was a problem hiding this comment.
Pull Request Overview
Refactors test data management by moving test datasets from R package data to test-scoped RDS files, removing schema validation tests, and cleaning up unused helper functions. This change improves package organization by keeping test-specific data separate from production package data.
- Test data moved from
usethis::use_data()tosaveRDS()in test directories - Removed 9 man pages for test data that are no longer exported
- Eliminated schema validation tests and related helper functions
Reviewed Changes
Copilot reviewed 36 out of 52 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-transform.R | Updated to load test data from RDS files instead of package data |
| tests/testthat/test-redcap_rights.R | Updated to load individual RDS files instead of combined test data object |
| tests/testthat/helper-package-specific.R | Removed schema conversion and table creation helper functions |
| Multiple test files | Removed schema validation tests |
| Multiple make_test_data.R files | Changed from usethis::use_data() to saveRDS() for test data creation |
| R/transform.R | Removed fix_data_in_redcap_log_event() function |
| R/data.R | Removed documentation for test data objects |
| man/*.Rd files | Removed man pages for test data |
| NAMESPACE | Removed export for deleted function |
| DESCRIPTION | Removed bit64 dependency |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Initialize invoice_line_item_test_data in each test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move test data from package scope to test scope.
Remove 9 man pages for test data that movwed to test scope. Remove tests that were only testing schema files.
Remove helpers used only by the removed tests.
Fix tests that needed the rescoped test data.