Skip to content

Move test data out of package space and remove tests of schema files#282

Merged
pbchase merged 2 commits intoctsit:developfrom
pbchase:remove_lousy_tests
Sep 29, 2025
Merged

Move test data out of package space and remove tests of schema files#282
pbchase merged 2 commits intoctsit:developfrom
pbchase:remove_lousy_tests

Conversation

@pbchase
Copy link
Copy Markdown
Contributor

@pbchase pbchase commented Sep 29, 2025

Move test data from package scope to test scope.
Remove 9 man pages for test data that movwed to test scope. Remove tests that were only testing schema files.
Remove helpers used only by the removed tests.
Fix tests that needed the rescoped test data.

Move test data from package scope to test scope.
Remove 9 man pages for test data that movwed to test scope.
Remove tests that were only testing schema files.
Remove helpers used only by the removed tests.
Fix tests that needed the rescoped test data.
@pbchase pbchase requested a review from Copilot September 29, 2025 19:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors test data management by moving test datasets from R package data to test-scoped RDS files, removing schema validation tests, and cleaning up unused helper functions. This change improves package organization by keeping test-specific data separate from production package data.

  • Test data moved from usethis::use_data() to saveRDS() in test directories
  • Removed 9 man pages for test data that are no longer exported
  • Eliminated schema validation tests and related helper functions

Reviewed Changes

Copilot reviewed 36 out of 52 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/testthat/test-transform.R Updated to load test data from RDS files instead of package data
tests/testthat/test-redcap_rights.R Updated to load individual RDS files instead of combined test data object
tests/testthat/helper-package-specific.R Removed schema conversion and table creation helper functions
Multiple test files Removed schema validation tests
Multiple make_test_data.R files Changed from usethis::use_data() to saveRDS() for test data creation
R/transform.R Removed fix_data_in_redcap_log_event() function
R/data.R Removed documentation for test data objects
man/*.Rd files Removed man pages for test data
NAMESPACE Removed export for deleted function
DESCRIPTION Removed bit64 dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread tests/testthat/test-transform.R
Initialize invoice_line_item_test_data in each test.
@pbchase pbchase merged commit b451004 into ctsit:develop Sep 29, 2025
1 check passed
@pbchase pbchase deleted the remove_lousy_tests branch September 30, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants