-
Notifications
You must be signed in to change notification settings - Fork 0
Yuna/notif flow #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yuna878
wants to merge
2
commits into
master
Choose a base branch
from
yuna/notif-flow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Yuna/notif flow #92
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
src/app/coursegrab/controllers/initialize_session_v2_controller.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| from os import environ | ||
| from google.auth.transport import requests | ||
| from google.oauth2 import id_token | ||
| from . import * | ||
| from ..utils.constants import IOS | ||
|
|
||
|
|
||
| class InitializeSessionV2Controller(AppDevController): | ||
| def get_path(self): | ||
| return "/session/initialize/v2/" | ||
|
|
||
| def get_methods(self): | ||
| return ["POST"] | ||
|
|
||
| def content(self, **kwargs): | ||
| data = request.get_json() | ||
| token = data.get("token") | ||
| device_type = data.get("device_type") | ||
| device_token = data.get("device_token") | ||
| given_name = data.get("given_name") | ||
| family_name = data.get("family_name") | ||
| try: | ||
| if device_type == IOS: | ||
| client_id = environ["IOS_CLIENT_ID"] | ||
| else: # device_type is ANDROID or WEB | ||
| client_id = environ["FIREBASE_CLIENT_ID"] | ||
|
|
||
| id_info = id_token.verify_oauth2_token(token, requests.Request(), client_id) | ||
| if id_info["iss"] not in ["accounts.google.com", "https://accounts.google.com"]: | ||
| raise ValueError("Wrong issuer.") | ||
|
|
||
| # ID token is valid. Get the user's Google Account information. | ||
| email, first_name, last_name = id_info.get("email"), id_info.get("given_name", given_name), id_info.get("family_name", family_name) | ||
| if email != "coursegrabappstore@gmail.com" and email[email.find("@") + 1 :] != "cornell.edu": | ||
| raise Exception("You must use a Cornell email") | ||
|
|
||
| user = users_dao.create_user(email, first_name, last_name) # Default notification mode = EMAIL | ||
| session = sessions_dao.create_session(user.id, device_type, device_token) | ||
| return session.serialize_session_v2() | ||
|
|
||
| except ValueError: | ||
| raise Exception("Invalid token") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,6 +14,7 @@ def content(self, **kwargs): | |
| data = request.get_json() | ||
| user = kwargs.get("user") | ||
|
|
||
| # DEPRECATED!!!! | ||
| # NONE is a constant imported from constants.py with string value "None" | ||
| # Following line of code converts the NONE="None" string value into Python's null value None | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. interesting i did not know this haha |
||
| notification = None if data.get("notification") == NONE else data.get("notification") | ||
|
|
||
15 changes: 15 additions & 0 deletions
15
src/app/coursegrab/controllers/update_session_v2_controller.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| from . import * | ||
|
|
||
|
|
||
| class UpdateSessionV2Controller(AppDevController): | ||
| def get_path(self): | ||
| return "/session/update/v2/" | ||
|
|
||
| def get_methods(self): | ||
| return ["POST"] | ||
|
|
||
| @extract_bearer | ||
| def content(self, **kwargs): | ||
| update_token = kwargs.get("bearer_token") | ||
| session = sessions_dao.refresh_session(update_token) | ||
| return session.serialize_session_v2() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm wouldnt people debugging want to know the reason behind the invalid token