Skip to content

Conversation

@ArielleNu
Copy link
Contributor

Overview

Dark mode compatibility was added with display theme switch capability created in SettingsDisplaySheetViewController.swift, which is within the settings view controller. Looks like A LOT of changes, but much of that is because I had to change a lot of the assets to add a Dark appearance, rather than only having the Any appearance. I also had to add new assets to support dark mode based on the Figma designs. The majority of the rest of the code is me going through every UI file ensuring that hard coded colors like .white and .black are removed and changed to dynamic colors added in assets.

Changes Made

Added a Display row in Settings that opens SettingsDisplaySheetViewController.swift on click

  • Created three modes: Light, Dark, Device Theme, with their appropriate icons.
  • Clicking the "Done" button triggers theme change

Adjusted hard-coded colors to allow for theme changing

  • Used Command + F to go through every file to make sure colors like .white or .black were no longer present in the code base since that would interfere with the dynamic theme changing
  • Replaced original colors so that a single color could have a dark and light version

Testing

  • Went through all of the views and checked if theme switching took place and matched up with the Sigma design.

Notes

  • Compatible with error screen changes from before.

Screen Recordings

Details
dark-mode.mp4
Details
dark-mode.2.mp4
Details
dark-mode.3.mp4
Details
dark-mode.4.mp4

Copy link

@AdelynnWu AdelynnWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING

@MrPeterss MrPeterss merged commit 2714811 into main Dec 7, 2025
4 of 5 checks passed
@MrPeterss MrPeterss deleted the arielle/diplay-themes branch December 7, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants