Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Dark mode compatibility was added with display theme switch capability created in
SettingsDisplaySheetViewController.swift, which is within the settings view controller. Looks like A LOT of changes, but much of that is because I had to change a lot of the assets to add a Dark appearance, rather than only having the Any appearance. I also had to add new assets to support dark mode based on the Figma designs. The majority of the rest of the code is me going through every UI file ensuring that hard coded colors like .white and .black are removed and changed to dynamic colors added in assets.Changes Made
Added a Display row in Settings that opens
SettingsDisplaySheetViewController.swifton clickAdjusted hard-coded colors to allow for theme changing
Testing
Notes
Screen Recordings
Details
dark-mode.mp4
Details
dark-mode.2.mp4
Details
dark-mode.3.mp4
Details
dark-mode.4.mp4