Google Auth - Integrate Auth into Navigation (Part 4) #4

AndrewCheung360 · 2025-09-26T22:09:39Z

Overview

Integrated auth changes into navigation code

Changes Made

Implemented Onboarding/Auth navgraph with sign in screen
Added profile screen to profile navgraph
Updated bottom navigation to use new icons
Added new routes for auth
Added navgraphs to main navigation and implemented navigation logic for sign in

Test Coverage

See recording below

Next Steps

Work with backend to use their auth routes
Use actual UI designs once they are finished

Related PRs or Issues

Screenshots

Screen.Recording.2025-09-26.at.3.32.38.PM.mov

Notes

Ignore the gradle or strings.xml changes (those are handled in related PR part 1)
Check andrew/google-auth branch for full change that spans the PRs

…ign out, minor change in empty HomeScreen

Copilot

Pull Request Overview

This PR integrates Google authentication into the app's navigation system, establishing the foundation for user sign-in functionality. The changes implement a complete authentication flow with proper navigation state management between authenticated and unauthenticated states.

Added Firebase Google Sign-In dependencies and configuration
Implemented onboarding navigation graph with sign-in screen
Updated bottom navigation to use custom icons and added Messages tab
Added navigation logic to handle authentication state transitions

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
gradle/libs.versions.toml	Added Firebase, credential manager, and Google ID dependencies for authentication
app/src/main/res/values/strings.xml	Added Google OAuth client ID for authentication configuration
app/src/main/java/com/cornellappdev/hustle/ui/navigation/navgraphs/ProfileNavigation.kt	Added profile screen with sign-out functionality
app/src/main/java/com/cornellappdev/hustle/ui/navigation/navgraphs/OnboardingNavigation.kt	New navigation graph for authentication flow with sign-in screen
app/src/main/java/com/cornellappdev/hustle/ui/navigation/Routes.kt	Added onboarding routes and renamed Favorites to Messages
app/src/main/java/com/cornellappdev/hustle/ui/navigation/HustleNavigation.kt	Integrated authentication state management and conditional navigation
app/src/main/java/com/cornellappdev/hustle/ui/navigation/BottomNavigation.kt	Updated to use drawable resources instead of material icons and added Messages tab
app/build.gradle.kts	Added Firebase, authentication, and credential manager dependencies

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-26T22:10:10Z

app/src/main/java/com/cornellappdev/hustle/ui/navigation/HustleNavigation.kt

+    LaunchedEffect(authUiState.isSignedIn) {
+        if (authUiState.isSignedIn) {
+            navController.navigate(HomeTab) {
+                popUpTo(0) { inclusive = true }
+            }
+        } else {
+            navController.navigate(Onboarding) {
+                popUpTo(0) { inclusive = true }
+            }
+        }
+    }


This LaunchedEffect will cause infinite navigation loops. When the user is already on HomeTab and signed in, or on Onboarding and signed out, this effect will still trigger navigation to the same destination, creating unnecessary navigation operations.

zachseidner1

Nice work, but we need to change the way we're injecting the VMs in this PR.

zachseidner1 · 2025-09-30T14:42:00Z

app/src/main/java/com/cornellappdev/hustle/ui/navigation/navgraphs/OnboardingNavigation.kt

+fun NavGraphBuilder.onboardingNavGraph(
+    signInWithGoogle: () -> Unit,
+    isLoading: Boolean,
+    errorMessage: String?,
+    clearError: () -> Unit


The navGraph itself should not have any parameters if possible. We should only inject the view model in the screen where it is used. If AuthViewModel is the view model for sign in screen, we should inject it directly as a parameter in SignInScreen, with SignInScreen(viewModel: AuthViewModel = hiltViewModel()). Also, if AuthViewModel is for SignInScreen, it should be renamed to SignInViewModel for clarity.

Ok that makes sense. My initial reasoning was because authviewmodel had some shared functions for multiple screens, but I think the functionality lives in the auth repository, so I could probably use it in separate viewmodels

zachseidner1 · 2025-09-30T14:42:31Z

app/src/main/java/com/cornellappdev/hustle/ui/navigation/navgraphs/ProfileNavigation.kt

+fun NavGraphBuilder.profileNavGraph(
+    user: User?,
+    onSignOut: () -> Unit,
+    isLoading: Boolean
+) {


yeah passing params like this that are specific to a screen in a navgraph doesn't make sense

sounds good, will probably move them into profile vm then instead

app/src/main/java/com/cornellappdev/hustle/ui/navigation/HustleNavigation.kt

zachseidner1 · 2025-09-30T14:45:33Z

app/src/main/java/com/cornellappdev/hustle/ui/navigation/HustleNavigation.kt

+    val authUiState = authViewModel.collectUiStateValue()
+    val startDestination = if (authUiState.isSignedIn) HomeTab else Onboarding


oh I see why you have this. I think for authenticated apps, it's more typical to have an initial loading screen and then just navigate to the right screen from there, or just always start on the Onboarding screen but have a LaunchedEffect that navigates to the correct screen once the user is signed in. This way you don't need authViewModel in HustleNavigation. Lmk if that makes sense.

I want to double check with you about this part. I think I agree that signinscreen could have its own view model with auth vm being renamed signin vm, but I'm trying to see if there is a better way to make sure that the user starts on the home screen if they logged in beforehand since I don't know if it is the best user experience if they always see the flicker from starting on the onboarding (or splash) into the home screen. I guess it's not the biggest deal lol, but figured it would be preferable to remove the flicker. I was wondering if it was possible if we had a root or main vm that deals with this sort of situation since authrepository can be shared among the vms or if there is a better practice we should follow?

zachseidner1 · 2025-09-30T14:47:21Z

app/src/main/java/com/cornellappdev/hustle/ui/navigation/HustleNavigation.kt

+            onboardingNavGraph(
+                signInWithGoogle = authViewModel::signInWithGoogle,
+                isLoading = authUiState.actionState == ActionState.Loading,
+                errorMessage = when (authUiState.actionState) {
+                    is ActionState.Error -> authUiState.actionState.message
+                    else -> null
+                },
+                clearError = authViewModel::clearActionState
+
+            )
            homeNavGraph(navController = navController)
-            favoritesNavGraph(navController = navController)
-            profileNavGraph(navController = navController)
+            messagesNavGraph(navController = navController)
+            profileNavGraph(
+                user = authUiState.user,
+                onSignOut = authViewModel::signOut,
+                isLoading = authUiState.actionState == ActionState.Loading
+            )


If you need to share actions across screens, those should probably be extracted to a repository. We should really only have 1 VM per screen, just to keep things simple and clear.

I think based on the previous comments, this will be resolved once we make it so the sign in and profile screens have their own vms that both use the auth repository functions as needed

… auth flow

AndrewCheung360 · 2025-10-01T04:47:34Z

I made separate vms for the respective screens and removed parameters from the navgraphs except for navcontroller. For the auth viewmodel in navigation composable issue, I ultimately went with the approach of having a root vm in mainactivity that has loading and signedin fields, where the loading field is used to determine how long the splash screen should show, and the signedin field is passed down eventually into the navigation composable to determine the starting destination so we can have the splash screen --> home screen directly if the user signed in already instead of splash screen --> sign in screen (briefly) --> home screen. Let me know if you have any questions about the approach or if there are some things that might not follow best practice with this approach. Wasn't 100% sure if this was the most ideal approach.

zachseidner1

This is a nice solution! I appreciate you figuring out something on your own to achieve the UX you wanted. This works well.

zachseidner1 · 2025-10-01T17:42:33Z

app/src/main/java/com/cornellappdev/hustle/util/auth/AuthUtils.kt

+import com.cornellappdev.hustle.ui.viewmodels.HustleViewModel
+import kotlinx.coroutines.launch
+
+fun <UiState> HustleViewModel<UiState>.executeAuthAction(


This function feels almost general enough that it could be its own executeActionStatefully, and just change the error message to something generic, like "An unknown error occurred". Then we could reuse it more later in the code. I recommend this name since it captures that we are modifying a state when executing the action.

AndrewCheung360 added 2 commits September 26, 2025 17:50

Implement Basic Sign In Screen, Implement basic profile screen with s…

a38acd3

…ign out, minor change in empty HomeScreen

Integrated google sign in to navigation + app

df07e4d

AndrewCheung360 requested a review from Copilot September 26, 2025 22:09

AndrewCheung360 changed the title ~~Google Auth - Integrate Auth into Navigation~~ Google Auth - Integrate Auth into Navigation (Part 4) Sep 26, 2025

Copilot AI reviewed Sep 26, 2025

View reviewed changes

AndrewCheung360 self-assigned this Sep 26, 2025

AndrewCheung360 added the enhancement New feature or request label Sep 26, 2025

AndrewCheung360 added 2 commits September 29, 2025 00:52

Made updates to reflect new auth vm changes

6f7870c

update nav based on auth vm changes

67055da

zachseidner1 requested changes Sep 30, 2025

View reviewed changes

AndrewCheung360 added 5 commits September 30, 2025 19:17

Merge branch 'main' into andrew/auth-screens

6dc1f56

Addressed PR comments - Updated parameter names and user null type

5e19c43

Resolve merge conflicts

4df4e20

Merge branch 'andrew/auth-screens' into andrew/auth-navigation

2de5de6

Addressed PR comments and added root vm with splash screen for better…

e16f622

… auth flow

AndrewCheung360 requested a review from zachseidner1 October 1, 2025 04:48

zachseidner1 approved these changes Oct 1, 2025

View reviewed changes

Generalized executeAuthAction util function

99c0679

AndrewCheung360 merged commit fe7a677 into main Oct 1, 2025
3 checks passed

AndrewCheung360 mentioned this pull request Nov 13, 2025

Auth - Integrate Backend Token Endpoints #7

Merged

		val authUiState = authViewModel.collectUiStateValue()
		val startDestination = if (authUiState.isSignedIn) HomeTab else Onboarding

Google Auth - Integrate Auth into Navigation (Part 4) #4

Google Auth - Integrate Auth into Navigation (Part 4) #4

Uh oh!

Conversation

AndrewCheung360 commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Changes Made

Test Coverage

Next Steps

Related PRs or Issues

Screenshots

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

zachseidner1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndrewCheung360 commented Oct 1, 2025

Uh oh!

zachseidner1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

AndrewCheung360 commented Sep 26, 2025 •

edited

Loading