Skip to content

Add missing data notice to cube details #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saterz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing data notice to cube details #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions src/routes/(public)/explore/cubes/[slug]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,29 @@
const presentFeatures = $derived.by(() =>
allFeatureBadges.filter((b) => features.includes(b.key))
);

const missingFields = $derived.by(() => {
const missing: string[] = [];
const trackIfMissing = (value: unknown, label: string) => {
if (
value === null ||
value === undefined ||
(typeof value === "string" && value.trim() === "")
) {
missing.push(label);
}
};

trackIfMissing(cube.brand, "Brand");
trackIfMissing(cube.type, "Type");
trackIfMissing(cube.release_date, "Release date");
trackIfMissing(cube.weight, "Weight");
trackIfMissing(cube.size, "Size");
trackIfMissing(cube.surface_finish, "Surface finish");
trackIfMissing(cube.image_url, "Image");

return missing;
});
</script>

<svelte:head>
Expand All @@ -40,6 +63,24 @@
</svelte:head>

<section class="space-y-6">
{#if missingFields.length > 0}
<div
class="alert alert-warning bg-warning/10 border border-warning text-warning-content"
role="status"
aria-live="polite"
>
<i class="fa-solid fa-circle-exclamation text-warning"></i>
<div>
<p class="font-semibold">Some cube details are missing</p>
<p class="text-sm opacity-80">
Missing:
{missingFields.join(", ")}. Have these details? Let us know so we can
fill them in.
</p>
</div>
</div>
{/if}

<!-- Overview / Description -->
<div class="p-5 bg-base-200 rounded-2xl border border-base-300 shadow-sm">
<h2 class="text-base font-semibold opacity-70 mb-2">About</h2>
Expand Down