Conversation
Sorry, forgot to take this out on the last commit.
| <li class="list-group-item">Regional Championships Announced! <a href="cubingusa.org">Read More</a></li> | ||
| <li class="list-group-item">Make sure to check out our new logo!</li> | ||
| </ul> | ||
|
|
There was a problem hiding this comment.
How does this look? I have it set up so it's different from the 'more links' card because it seems more important. I have the layout for making it a normal card header commented out for now. Do people want this to look different, or have it the same as the 'more links' style?
|
|
||
| <!-- Example posts for now --> | ||
| <ul class="list-group"> | ||
| <li class="list-group-item">Posts will appear here <i class="fa fa-trash float-right"></i> <i class="fa fa-edit float-right"></i></li> |
There was a problem hiding this comment.
FA icons need some formatting, they're there just as placeholders
|
|
||
| <h1>CubingUSA Announcements</h1> | ||
|
|
||
| <div style="margin-top:30px;"> |
There was a problem hiding this comment.
Is this kind of inline CSS okay, or should I make a separate style file for the announcements?
There was a problem hiding this comment.
I prefer to not have inline styling. As the project grows it will only get harder to move the inline styling out into separate files.
|
Anyone have thoughts on this? |
|
Can you provide a staging link or screenshot? |
|
I toggled the base branch to make the extra commits disappear since they were already merged into I agree with @ToastyKen, I'd like to see some screenshots as well! |
|
Hey all, Sorry about the delay in this, classes really made me lose track of time at the end of the semester. Anyways, now I'll have a lot more time to fiddle with this. Since it seemed a bit much to set up staging for style choices, I added a folder to the webmaster google drive and put the pictures there. Which do people like better? Personally, I think the default list without the card style (the list.png picture) would be better. |
3 participants
(Sorry about having the personnel updates in here, I created a new branch while having checked that one out, so it brought these with it) @timreyn What is the best way to go about adding the announcements to the datastore. should I make a separate handler, similar to this?