Skip to content
This repository was archived by the owner on Apr 26, 2021. It is now read-only.

Conversation

@cccs-kevin
Copy link

Thanks for contributing! But first: did you read our community guidelines?
https://cuckoo.sh/docs/introduction/community.html

What I have added/changed is:

Create process memory dumps only if the desire is there (aka it's specified explicitly in self.analyzer.config.options as procmemdump=1).

The goal of my change is:

If you do not explicitly want process memory dumps, you shouldn't have to deal with the additional processing time of uploading .dmp files or the inflated size of the cuckoo tar ball post-analysis. This configuration option is already used here:

if self.analyzer.config.options.get("procmemdump"):
, and I believe that the configuration option should be used everywhere dump_memory is called.

What I have tested about my change is:

Manual testing to ensure correct functionality.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant