Skip to content

refactor: add attachment timestamp #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luke-hill merged 3 commits into from
Dec 16, 2025
+4 −7
Merged

refactor: add attachment timestamp #1809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0628e0
WIP: Add #timestamp to Attachment message
luke-hill Dec 12, 2025
2c3a561
Cleanups
luke-hill Dec 16, 2025
95bb15d
Remove 3.1 testing whilst we have a slow transition out of 3.1 support
luke-hill Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
ruby: ['3.1', '3.2', '3.3', '3.4']
ruby: ['3.2', '3.3', '3.4']
include:
- os: ubuntu-latest
ruby: jruby-9.4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
ruby: ['3.1', '3.2', '3.3', '3.4']
ruby: ['3.2', '3.3', '3.4']
include:
- os: ubuntu-latest
ruby: jruby-9.4
Expand Down
7 changes: 2 additions & 5 deletions lib/cucumber/formatter/message_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,13 @@ def initialize(config)
@current_test_step_id = nil
end

def output_message
raise 'To be implemented'
end

def attach(src, media_type, filename)
attachment_data = {
test_step_id: @current_test_step_id,
test_case_started_id: @current_test_case_started_id,
media_type: media_type,
file_name: filename
file_name: filename,
timestamp: time_to_timestamp(Time.now)
}

if media_type&.start_with?('text/')
Expand Down
Loading