Transfer directo and Fintoc

[rogelioLpz]

Summary by CodeRabbit

• New Features

  • Added support for two new banks: Transfer directo and Fintoc, expanding available banking options.

• Chores

  • Version updated to 2.1.6.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR adds two new bank code mappings to the CLABE banking system: code '727' maps to bank code '90727' (Transfer directo), and code '738' maps to '90738' (Fintoc). Additionally, the package version is bumped from '2.1.5' to '2.1.6'. All changes are dictionary entry additions and version constant updates with no modifications to control flow or function signatures.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Simple dictionary entry additions with no logic changes
• Straightforward version string update
• Homogeneous, cosmetic changes across minimal files

Possibly related PRs

• clabe-python#178: Modifies the same BANKS and BANK_NAMES dictionaries by adding new bank code and name entries
• clabe-python#179: Updates entries in the BANK_NAMES and BANKS dictionaries with new or modified bank mappings
• clabe-python#176: Makes similar additions and removals to BANKS and BANK_NAMES dictionary entries

Suggested reviewers

• felipao-mx
• gmorales96

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly matches the primary change: adding two new bank mappings ('Transfer directo' and 'Fintoc') to the BANKS and BANK_NAMES dictionaries.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch add-new-banks

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ccf338 and 97633b5.

📒 Files selected for processing (2)

• clabe/banks.py (3 hunks)
• clabe/version.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.py

⚙️ CodeRabbit configuration file

**/*.py: Enforce Relative Imports for Internal Modules

Ensure that any imports referencing internal modules use relative paths. However, if modules reside in the main module directories (for example /src or /library_or_app_name) —and relative imports are not feasible—absolute imports are acceptable. Additionally, if a module is located outside the main module structure (for example, in /tests or /scripts at a similar level), absolute imports are also valid.

Examples and Guidelines:

1. If a module is in the same folder or a subfolder of the current file, use relative imports. For instance: from .some_module import SomeClass
2. If the module is located under /src or /library_or_app_name and cannot be imported relatively, absolute imports are allowed (e.g., from library_or_app_name.utilities import helper_method).
3. If a module is outside the main module directories (for example, in /tests, /scripts, or any similarly placed directory), absolute imports are valid.
4. External (third-party) libraries should be imported absolutely (e.g., import requests).

**/*.py:
Rule: Enforce Snake Case in Python Backend

1. New or Modified Code: Use snake_case for all variables, functions, methods, and class attributes.
2. Exceptions (Pydantic models for API responses):
   • Primary fields must be snake_case.
   • If older clients expect camelCase, create a computed or alias field that references the snake_case field.
   • Mark any camelCase fields as deprecated or transitional.

Examples

Invalid:

class CardConfiguration(BaseModel):
    title: str
    subTitle: str  # ❌ Modified or new field in camelCase

Valid:

class CardConfiguration(BaseModel):
    title: str
    subtitle: str  # ✅ snake_case for new/modified field

    @computed_field
    def subTitle(self) -> str:  # camelCase allowed only for compatibility
        return self.subtitle

Any direct use of camelCase in new or updated code outside of these exceptions should be flagged.

`*...

Files:

• clabe/version.py
• clabe/banks.py

🔇 Additional comments (3)

clabe/version.py (1)

1-1: LGTM! Version bump aligns with new bank additions.

The version increment from '2.1.5' to '2.1.6' is appropriate for adding new bank code mappings.

clabe/banks.py (2)

95-96: LGTM! New bank codes follow existing patterns.

The new bank mappings are correctly structured and consistent with the existing dictionary entries.

---

151-151: LGTM! Bank names correctly placed in alphabetical order.

Both 'Fintoc' and 'Transfer directo' are correctly positioned in alphabetical order as required by the comment on line 102, and they properly correspond to their respective bank codes in the BANKS dictionary.

Also applies to: 191-191

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (1ccf338) to head (97633b5).

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines           83        83           
=========================================
  Hits            83        83           

Flag	Coverage Δ
unittests	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
clabe/banks.py	100.00% <ø> (ø)
clabe/version.py	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ccf338...97633b5. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.