Unique Prefix ID from svg filename to prevent svg id collision#3
Open
SilverFox70 wants to merge 17 commits intocupojoe:masterfrom
Open
Unique Prefix ID from svg filename to prevent svg id collision#3SilverFox70 wants to merge 17 commits intocupojoe:masterfrom
SilverFox70 wants to merge 17 commits intocupojoe:masterfrom
Conversation
Feature/create unique id prefix
chore: remove logging line
feat: add another test and update variable name in test file
Feat/add test
…ntegration test for above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Haven't had time to go back over this with a fine tooth comb since I made these changes, but it is working fine on two separate production sites at this point. It could be made more robust by implementing a 'usable' default prefix based on something like
shortid, but that would meaning adding dependencies: seelib/sanitize/filters/unique-svg-ids.jsat line line 7 for more info.