Fix fail test by Atelange · Pull Request #19 · curefit/CultStore_Web_UI_Automation

Atelange · 2026-03-09T11:43:56Z

Made changes for the chromedriver to isolate antibote detection

Copilot

Pull request overview

Updates the Selenium TestNG headless setup to reduce bot-detection failures in CI (Chrome/Chromedriver), while also adjusting a few UI test interactions/selectors and removing an unused load-test class.

Changes:

Removed SeleniumLoadTest (ad-hoc threaded load test).
Expanded HeadlessBaseTest ChromeOptions + CDP masking, added retry startup and richer debugging artifacts, and updated several waits/interactions.
Updated page objects/selectors used by “Unlock offers” and cart offer flows.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
src/test/java/Test/SeleniumLoadTest.java	Removed the standalone load-test runner.
src/test/java/Test/HeadlessBaseTest.java	Major headless Chrome configuration changes (anti-bot masking, retry logic, debug output) plus multiple test flow wait updates and failure artifact capture.
src/test/java/Test/BaseTest.java	Updates selectors/flows for unlock-offers and cart-offers scenarios; removes an unused import.
src/test/java/Pages/UnlockOffers.java	Adds brand/color filter interactions and updates the shoe selector used by unlock-offers tests.
src/test/java/Pages/CartOffers.java	Makes the sports-bra selector less brittle by matching a prefix.
src/test/java/Pages/CartCheckout.java	Adjusts driver field visibility/constructor placement; leaves commented code.

Comments suppressed due to low confidence (1)

src/test/java/Test/HeadlessBaseTest.java:209

This @BeforeMethod takes and stores a screenshot even on successful runs. For larger suites this can be expensive and flood CI artifacts; prefer capturing screenshots only on failure (you already do this in teardown) or when bot-block is detected.

        try {
            java.io.File screenshot = ((org.openqa.selenium.TakesScreenshot) driver)
                .getScreenshotAs(org.openqa.selenium.OutputType.FILE);
            java.nio.file.Files.copy(screenshot.toPath(), 
                new java.io.File("target/debug-homepage-" + System.currentTimeMillis() + ".png").toPath(),
                java.nio.file.StandardCopyOption.REPLACE_EXISTING);
            System.out.println("Screenshot saved to target/ directory");

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-09T11:48:39Z

+    By colorfilter = By.xpath("//div[normalize-space()='Color']");
+    public void clickColorFilter() {
+        driver.findElement(colorfilter).click();
+    }


UnlockOffers now has both colorfilter (new) and colourfilter (existing) locators/methods for the same UI concept. This duplication is confusing and easy to drift; consolidate to a single locator/method and use consistent naming.

Copilot · 2026-03-09T11:48:40Z

+        // Enable JavaScript (some sites check)
+        options.addArguments("--enable-javascript");


--enable-javascript is not a standard Chrome command-line switch (JavaScript is enabled by default). Passing unknown/invalid flags can cause noisy warnings or, in some environments, startup failures; remove this flag (or only use --disable-javascript when you explicitly want it off).

Copilot · 2026-03-09T11:48:40Z

        options.addArguments("--disable-web-security");
-
-        // The "Masking" kit from BaseTest
-        options.setExperimentalOption("excludeSwitches", java.util.Collections.singletonList("enable-automation"));
+        options.addArguments("--allow-running-insecure-content");


Disabling web security / allowing insecure content (--disable-web-security, --allow-running-insecure-content) significantly changes browser behavior and can mask real issues (CORS/mixed-content) in UI flows. If this is only needed for specific anti-bot experiments, gate it behind an env flag and keep the default secure configuration.

Copilot · 2026-03-09T11:48:40Z

+            java.nio.file.Files.writeString(
+                java.nio.file.Path.of("target/debug-page-source-" + System.currentTimeMillis() + ".html"),
+                pageSource
+            );
+            System.out.println("Page source saved to target/ directory");


This @BeforeMethod writes the full page source to target/ unconditionally. That can bloat CI artifacts and slow runs; consider writing it only when possibleBotBlock is true or when a debug env flag is enabled.

Copilot · 2026-03-09T11:48:40Z

+       // wait.until(ExpectedConditions.elementToBeClickable(By.xpath("(//div[@class='cart-offer-callout-card-header'])[1]"))); //(//div[@class='cart-offer-callout-card-header'])[1]
+       // unlockOffers.isBestOfferTextDisplayed("Best Offer - Apply at Checkout");


Leaving commented-out waits/assertions in a test makes it unclear what the intended verification is and reduces coverage for the offers modal content. Either restore an assertion that verifies the expected text/state, or remove the dead commented code and replace with a stable check.

Copilot · 2026-03-09T11:48:41Z

+  //  WebDriver driver;
+


Please remove the commented-out // WebDriver driver; line; commented code in page objects adds noise and makes it unclear which driver field should be used.

Copilot · 2026-03-09T11:48:41Z

        options.addArguments("--window-size=1920,1080");
        options.addArguments("--disable-popup-blocking");


--window-size=1920,1080 sets the viewport at Chrome startup, but later the test also calls driver.manage().window().setSize(...). Having both is redundant and can lead to confusion about which size is actually in effect; prefer keeping only one approach.

Copilot · 2026-03-09T11:48:41Z

+        // Accept languages/encoding to look like a real browser
+        options.addArguments("--lang=en-US,en;q=0.9");
+        options.addArguments("--accept-encoding=gzip, deflate, br");


--accept-encoding=... is an HTTP header concept, not a supported Chrome startup argument, and the value here includes spaces. This is likely ignored or treated as an unknown flag; drop it and, if you need to control headers, set them via CDP/DevTools on requests instead.

Copilot · 2026-03-09T11:48:41Z

        wait.until(ExpectedConditions.visibilityOfElementLocated(By.xpath("(//div[@class='product-discount-additional'])[1]")));
        unlockOffers.isAdditonalOffersSectionDisplayed("Additional offers for you");


isAdditonalOffersSectionDisplayed(...) returns a boolean but the result is ignored, so this step doesn't actually validate anything. Convert this into an assertion (or remove the helper call if it’s not meant to assert).

Atelange added 2 commits March 9, 2026 16:04

Small fixes

8f4c8f4

deva pls he solution work hou dya

43e397d

Copilot AI review requested due to automatic review settings March 9, 2026 11:43

Copilot started reviewing on behalf of Atelange March 9, 2026 11:44 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix fail test#19

Fix fail test#19
Atelange wants to merge 2 commits intomasterfrom
Fix_fail_test

Atelange commented Mar 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Copilot AI Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// Enable JavaScript (some sites check)
		options.addArguments("--enable-javascript");

		// wait.until(ExpectedConditions.elementToBeClickable(By.xpath("(//div[@class='cart-offer-callout-card-header'])[1]"))); //(//div[@class='cart-offer-callout-card-header'])[1]
		// unlockOffers.isBestOfferTextDisplayed("Best Offer - Apply at Checkout");

		options.addArguments("--window-size=1920,1080");
		options.addArguments("--disable-popup-blocking");

		wait.until(ExpectedConditions.visibilityOfElementLocated(By.xpath("(//div[@class='product-discount-additional'])[1]")));
		unlockOffers.isAdditonalOffersSectionDisplayed("Additional offers for you");

Conversation

Atelange commented Mar 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants