fix pat impersonation for datalake#5
Merged
AbhishekGedela merged 1 commit intomasterfrom Apr 14, 2026
Merged
Conversation
nileshsinha1993
approved these changes
Apr 14, 2026
There was a problem hiding this comment.
Pull request overview
This PR adjusts Starburst/Trino session-user impersonation behavior to handle PAT-based authentication for a specific “datalake” database case.
Changes:
- Fetches the current database from the metadata provider during execution.
- Introduces a
force-pat-user?path that sets/clears TrinosessionUserfor PAT auth even when the existingimpersonate:trueclientInfo flag is not present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+165
to
+168
| (let [database (lib.metadata/database (qp.store/metadata-provider)) | ||
| impersonation-enabled? (clojure.string/includes? (.getProperty (.getClientInfo conn) "ClientInfo" "") "impersonate:true") | ||
| force-pat-user? (and (= api/*current-auth-type* :pat) | ||
| (contains? #{39} (:id database)))] |
Comment on lines
+179
to
+182
| (let [database (lib.metadata/database (qp.store/metadata-provider)) | ||
| impersonation-enabled? (clojure.string/includes? (.getProperty (.getClientInfo conn) "ClientInfo" "") "impersonate:true") | ||
| force-pat-user? (and (= api/*current-auth-type* :pat) | ||
| (contains? #{39} (:id database)))] |
Comment on lines
+167
to
174
| force-pat-user? (and (= api/*current-auth-type* :pat) | ||
| (contains? #{39} (:id database)))] | ||
| (if | ||
| (or impersonation-enabled? force-pat-user?) | ||
| (let [session-user (if (= api/*current-auth-type* :pat) | ||
| "pat_user" | ||
| (get (deref api/*current-user*) :email))] | ||
| (.setSessionUser (.unwrap conn TrinoConnection) session-user)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.