Back drop fix.#96
Open
umangdarji-dev wants to merge 2 commits intomasterfrom
Open
Conversation
kunal15595
approved these changes
Feb 17, 2020
Contributor
|
Why are we making this change ? Modal should close on clicking the backdrop
…On Mon, Feb 17, 2020 at 5:02 PM Kunal Khandelwal ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#96?email_source=notifications&email_token=AFC7FWB6VQRXXNGFICDPUJDRDJYTDA5CNFSM4KWPVYPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVYB6LA#pullrequestreview-359669548>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFC7FWHOL3CRFTHD4TK7YZTRDJYTDANCNFSM4KWPVYPA>
.
|
ankitcf
suggested changes
Feb 17, 2020
Contributor
ankitcf
left a comment
ankitcf
left a comment
There was a problem hiding this comment.
We should close the modal on clicking the backdrop
Member
|
Even I use this behaviour, but I have seen it becoming a problem for a lot
of new users.
We can always close the modal by closing on cross button.
…On Mon, Feb 17, 2020 at 5:05 PM Ankit Gupta ***@***.***> wrote:
***@***.**** requested changes on this pull request.
We should close the modal on clicking the backdrop
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#96?email_source=notifications&email_token=ABKQAKTRO7GPOCEJGU3GY2TRDJY6TA5CNFSM4KWPVYPKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVYCKTQ#pullrequestreview-359671118>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKQAKTI2DVZTWUOGZAAGQ3RDJY6TANCNFSM4KWPVYPA>
.
--
Kunal Khandelwal
Software Engineer - API
|
Contributor
Author
We have added all the information in modal and then if we accidentally clicked on backdrop it will close the modal and our data what we have filled previously will lost that's why I have added this. |
Contributor
|
This is the default behaviour for all bootstrap modal in the world. I am
assuming they have done some research and have deeper insights than the 3
of us.
If a particular dashboard wants it, they should be able to pass this as an
option.
Role of react crux is not to fix bootstraps mistakes
…On Mon, 17 Feb, 2020, 5:09 pm Umang Darji, ***@***.***> wrote:
We should close the modal on clicking the backdrop
We have added all the information in modal and then if we accidentally
clicked on backdrop it will close the modal and our data what we have
filled previously will lost that's why I have added this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#96?email_source=notifications&email_token=AFC7FWB5QTLJ47NADBJN7ITRDJZQ7A5CNFSM4KWPVYPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL6DIYY#issuecomment-586953827>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFC7FWE3ROG4VDSDPQOPT3DRDJZQ7ANCNFSM4KWPVYPA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.