Skip to content

rn 0.76 updates#34

Open
somya-goyal-curefit wants to merge 1 commit intomasterfrom
rn-update
Open

rn 0.76 updates#34
somya-goyal-curefit wants to merge 1 commit intomasterfrom
rn-update

Conversation

@somya-goyal-curefit
Copy link
Copy Markdown

Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:

Update the documentation

If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.

Update the changelog

After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.

Provide an example of how to test the change

If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.

Focus the PR on only one area

Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.

Describe the changes

Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the codebase for compatibility with React Native 0.76. The changes address breaking changes in React Native 0.76 where PropTypes were removed from core components, and updates ExoPlayer resource ID references to use fully qualified names to avoid potential conflicts.

  • Updates ExoPlayer resource ID references in Android to use fully qualified package names
  • Migrates from deprecated Image.propTypes to ImagePropTypes from the deprecated-react-native-prop-types package

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java Updates ExoPlayer resource ID references to use fully qualified com.google.android.exoplayer2.R.id prefix for play and pause buttons
Video.js Adds ImagePropTypes import and updates posterResizeMode propType to use ImagePropTypes.resizeMode instead of deprecated Image.propTypes.resizeMode

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants