Replace DelimitedArrayOfT usage with ArraySegment #33#34
Merged
anders9ustafsson merged 1 commit intomainfrom Oct 26, 2025
Merged
Replace DelimitedArrayOfT usage with ArraySegment #33#34anders9ustafsson merged 1 commit intomainfrom
anders9ustafsson merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the custom DelimitedArray<T> implementation with the built-in ArraySegment<T> type. The custom class was originally created to provide safe array slicing without using unsafe code, but ArraySegment<T> serves the same purpose and is a standard .NET type.
Key changes:
- Removed the custom
DelimitedArray<T>class entirely - Updated all usages to use
ArraySegment<double>instead - Removed the
dvecparameter frommp_fdjac2method and made it a local variable - Simplified array segment creation by using
ArraySegment<T>constructor directly instead of mutation methods
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/MPFitLib/MPFit.cs | Replaced DelimitedArray<double> with ArraySegment<double> throughout; removed dvec parameter from mp_fdjac2 and made it local; replaced mutation methods with direct construction |
| src/MPFitLib/DelimitedArrayOfT.cs | Deleted entire custom DelimitedArray<T> class implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.