Change signature for mp_result in Solve #35#37
Merged
anders9ustafsson merged 1 commit intomainfrom Oct 27, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR changes the signature of the Solve method to use a regular parameter instead of a ref parameter for the mp_result argument. The change makes all optional parameters have default values and removes the ref keyword from the result parameter, simplifying the API for callers.
Key Changes:
- Modified the
Solvemethod signatures to removereffrom theresultparameter and add default values to optional parameters - Updated all test method calls to pass
resultwithout therefkeyword - Relocated a variable declaration in
mp_fdjac2method (moved after comment block)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/MPFitLib/MPFit.cs | Updated two Solve method overloads to remove ref from result parameter, added default values to optional parameters, and moved dvec variable declaration |
| src/MPFitLib.Test/TestMPFit.cs | Removed ref keyword from all MPFit.Solve calls in test methods to align with the new signature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.