Skip to content

refactor: form tabs #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DanielSchiavini merged 16 commits into from
Dec 4, 2025
Merged

refactor: form tabs #1730

DanielSchiavini merged 16 commits into from
Dec 4, 2025

Conversation

@DanielSchiavini
Copy link
Collaborator

@DanielSchiavini DanielSchiavini commented Dec 2, 2025 •
edited
Loading

For upcoming PRs:

  • implement tabs in mint refactor: merge mint create and manage loan pages #1749
    • loan creation
    • loan management
    • soft liquidation (shared)
    • merge all market pages
    • get rid of extra formType in URL
    • merge create and manage pages
  • implement tabs in DEX
    • pools
    • get rid of extra formType in URL

@vercel
Copy link

vercel bot commented Dec 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
curve-dapp Ready Ready Preview Comment Dec 3, 2025 3:26pm
curve-dapp-storybook Ready Ready Preview Comment Dec 3, 2025 3:26pm

0xAlunara
0xAlunara reviewed Dec 2, 2025
View reviewed changes
@DanielSchiavini DanielSchiavini mentioned this pull request Dec 3, 2025
Open
@DanielSchiavini DanielSchiavini marked this pull request as ready for review December 3, 2025 11:03
0xtutti
0xtutti previously approved these changes Dec 3, 2025
View reviewed changes
0xAlunara
0xAlunara reviewed Dec 3, 2025
View reviewed changes
@DanielSchiavini DanielSchiavini merged commit e12dcce into main Dec 4, 2025
25 of 26 checks passed
@DanielSchiavini DanielSchiavini deleted the refactor/routes branch December 4, 2025 16:16
0xAlunara added a commit that referenced this pull request Dec 5, 2025
@0xAlunara
Revert "Merge pull request #1730 from curvefi/refactor/routes"
0d1d520 
This reverts commit e12dcce, reversing
changes made to b9c913f.
0xAlunara added a commit that referenced this pull request Dec 5, 2025
@0xAlunara
Merge pull request #1745 from curvefi/revert/refactor/routes
07df2c4 
revert: "Merge pull request #1730 from curvefi/refactor/routes"
@0xAlunara 0xAlunara mentioned this pull request Dec 5, 2025
Merged
DanielSchiavini added a commit that referenced this pull request Dec 8, 2025
@DanielSchiavini
Revert "revert: "Merge pull request #1730 from curvefi/refactor/routes""
ca1e251
@DanielSchiavini DanielSchiavini mentioned this pull request Dec 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xPearce 0xPearce 0xPearce approved these changes

@0xAlunara 0xAlunara 0xAlunara approved these changes

@0xtutti 0xtutti 0xtutti left review comments

@OnlyJousting OnlyJousting Awaiting requested review from OnlyJousting

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DanielSchiavini @0xPearce @0xAlunara @0xtutti