feat: add erc4626 token check to pool creation #1740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OnlyJousting
force-pushed
the
feat/add-erc4626-token-check-to-pool-creation
branch
from
ce2ca61 to
da0687b
Compare
OnlyJousting
requested review from
0xAlunara,
0xPearce,
0xtutti and
DanielSchiavini
apps/main/src/dex/components/PageCreatePool/hooks/useAutoDetectErc4626.ts
Outdated
Show resolved
Hide resolved
apps/main/src/dex/components/PageCreatePool/hooks/useAutoDetectErc4626.ts
Outdated
Show resolved
Hide resolved
apps/main/src/dex/components/PageCreatePool/hooks/useIsErc4626.ts
Outdated
Show resolved
Hide resolved
apps/main/src/dex/components/PageCreatePool/hooks/useIsErc4626.ts
Outdated
Show resolved
Hide resolved
0xAlunara
previously approved these changes
Dec 9, 2025
DanielSchiavini
requested changes
Dec 10, 2025
apps/main/src/dex/components/PageCreatePool/hooks/useAutoDetectErc4626.ts
Outdated
Show resolved
Hide resolved
apps/main/src/dex/components/PageCreatePool/hooks/useAutoDetectErc4626.ts
Show resolved
Hide resolved
apps/main/src/dex/components/PageCreatePool/hooks/useAutoDetectErc4626.ts
Outdated
Show resolved
Hide resolved
…://github.com/curvefi/curve-frontend into feat/add-erc4626-token-check-to-pool-creation
DanielSchiavini
previously approved these changes
Dec 12, 2025
apps/main/src/dex/components/PageCreatePool/hooks/useAutoDetectErc4626.ts
Show resolved
Hide resolved
apps/main/src/dex/components/PageCreatePool/hooks/useAutoDetectErc4626.ts
Outdated
Show resolved
Hide resolved
0xAlunara
previously approved these changes
Dec 12, 2025
OnlyJousting
dismissed stale reviews from DanielSchiavini and 0xAlunara
via
4e913c9
DanielSchiavini
approved these changes
Dec 15, 2025
0xAlunara
approved these changes
Dec 15, 2025
OnlyJousting
deleted the
feat/add-erc4626-token-check-to-pool-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a on chain read to check and verify if a selected token is of type ERC4626, if it is, the ERC4626 asset type gets automatically pre-selected. The user can change the asset type but if it's a verified ERC4626 token, the UI will display a warning:
Changes: