feat: Pool alert banner #1741
Merged
feat: Pool alert banner #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0xPearce
commented
Dec 16, 2025
apps/main/src/dex/components/PagePool/Deposit/components/FormDeposit.tsx
Outdated
Show resolved
Hide resolved
0xAlunara
approved these changes
Dec 16, 2025
DanielSchiavini
approved these changes
Dec 17, 2025
Collaborator
DanielSchiavini
left a comment
DanielSchiavini
left a comment
There was a problem hiding this comment.
Looks good to me, comments are nitpick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to make warnings, errors, and alerts consistent across the DEX pools. What I did was split the old messages into a banner and a form alert message.
I didn’t refactor the form alert message, so it can look a bit odd between the new banner style and the old form alert message, but this can be done in another PR.
I also tried to migrate to MUI as much as possible. I tried using the Typography component, but it was too inconsistent with the current design.