fix: loan query validation #1762
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
apps/main/src/llamalend/queries/validation/borrow-fields.validation.ts
Outdated
Show resolved
Hide resolved
apps/main/src/llamalend/queries/create-loan/create-loan-route-image.query.ts
Outdated
Show resolved
Hide resolved
|
When simulating a max loan on "high ltv" and switching over to "safe" there is no error being shown in the form about the debt being too high. The value in "max borrow" is also not possible to click to update the "borrow" input Screen.Recording.2025-12-15.at.5.43.11.movI was able to initiate a transaction with an incorrect "borrow" value in the input 
|
|
This branch also has broken styles for the action form sub nav and the self-liquidate section but it is probably unrelated to this PR |
Thank you, that was a good point. Apparently the vest form only validates fields that change, so if the debt is changed, we need to revalidate the maxDebt and vice-versa 😞 The fix is in 987d1e0 but I'd like to add some tests
Yes I've seen this before, indeed. I fixed it in one of the follow-up PRs: |
|
Now the "debt too high" error remains after updating the "borrow" value to "max": Screen.Recording.2025-12-15.at.19.44.29.mov |
I believe you checked an outdated version, the test I introduced does exactly this and it's passing |
| * This is necessary because passing UseQueryResult to any react component will crash the rendering due to | ||
| * react trying to serialize the react-query proxy object. | ||
| */ | ||
| const q = <T,>({ data, isLoading, error }: UseQueryResult<T>): Query<T> => ({ |
There was a problem hiding this comment.
Souldn't we export it and place it in some utils to be reused elsewhere?
There was a problem hiding this comment.
Sure, I'll move it as soon as it's used in the follow-up PR
| sliderProps?: SliderInputProps<Decimal>['sliderProps'] | ||
|
|
||
| /** Optional children to be rendered below the input */ | ||
| children?: ReactNode |
There was a problem hiding this comment.
We should update the storybook maybe?
There was a problem hiding this comment.
Good idea, I'll do that in another PR
Uh oh!
There was an error while loading. Please reload this page.