Skip to content

Fix modded ore generation in Advanced Mining Dimension#38

Draft
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-37
Draft

Fix modded ore generation in Advanced Mining Dimension#38
Copilot wants to merge 2 commits intomasterfrom
copilot/fix-37

Conversation

Copy link
Contributor

Copilot AI commented Aug 29, 2025

Resolves the issue where modded and Forge ores were not spawning in the Advanced Mining Dimension, with only vanilla ores generating at sparse rates.

Problem

The Advanced Mining Dimension was only generating vanilla ores (iron, coal, diamond, etc.) and missing all modded ores from installed mods like:

  • Mekanism: Osmium, Tin, Uranium
  • Thermal Series: Lead, Silver, Nickel
  • Other tech mods: Various additional ores

This significantly impacted late-game resource gathering efficiency since players couldn't obtain modded materials from the dedicated mining dimension.

Solution

Implemented a comprehensive multi-layered approach to ensure modded ore generation:

1. Direct Mod Configuration

Added advanced-mining-dimension.toml with settings to:

  • Enable modded ore generation
  • Increase ore generation multiplier to 1.5x (addressing sparse generation)
  • Include Forge ore tags in worldgen

2. Comprehensive Datapack

Created mining_dimension_modded_ores datapack with multiple redundant approaches:

Forge Biome Modifiers: Three different targeting strategies:

// Specific biome targeting
"biomes": ["advanced_mining_dimension:mining_dimension"]

// Common biome tags
"biomes": "#c:mining_dimension"

// Fallback for all dimensions
"biomes": { "type": "forge:all" }

Worldgen Integration: Added modded ore features to the underground_ores generation step, ensuring they spawn at appropriate depths alongside vanilla ores.

3. Modded Ores Included

  • Mekanism: ore_osmium, ore_tin, ore_uranium
  • Thermal: ore_tin, ore_lead, ore_silver, ore_nickel

Technical Details

  • Uses Minecraft 1.20.1 datapack format (pack_format: 15)
  • Integrates seamlessly with existing OpenLoader system
  • Follows established patterns from existing pack datapacks (ftb_ultimine_ores_only)
  • Minimal impact approach - only adds ore generation without modifying existing systems

The multi-layered approach ensures compatibility regardless of how the Advanced Mining Dimension mod implements its biome system, providing redundant coverage to guarantee modded ore generation works reliably.

Fixes #37.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: cwage <190973+cwage@users.noreply.github.com>
Copilot AI changed the title [WIP] Modded/Forge ores don't spawn in mining dimension, vanilla ores only Fix modded ore generation in Advanced Mining Dimension Aug 29, 2025
Copilot AI requested a review from cwage August 29, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modded/Forge ores don't spawn in mining dimension, vanilla ores only

2 participants

Comments