Conversation
- Replace theme-dependent icon with high-quality PNG from vectorified.com - Use inverted (white) speaker icon for better visibility across all themes - Remove complex dynamic volume bar functionality that was causing crashes - Simple, clean, and reliable icon that works on both light and dark themes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves system tray icon visibility by replacing a theme-dependent system icon with a custom white speaker PNG image, ensuring consistent visibility across different desktop themes. The changes also include simplification of the icon loading code and addition of GitHub workflow conditions.
Key changes:
- Custom PNG icon loading with fallback to system icon
- Simplified icon loading code for better reliability
- Added GitHub workflow condition checks for version input
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/volmix.c | Replaces system icon with custom PNG loading logic and fallback mechanism |
| .github/workflows/create-release.yml | Adds conditional checks to prevent jobs from running without version input |
- Use g_build_filename() for secure path construction - Add file existence validation before loading icon - Replace printf() with g_print() for success messages - Replace printf() with g_warning() for error messages - Proper memory management with g_free() for allocated paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test plan
This resolves the barely-visible black speaker icon issue and provides a clean, professional appearance.