Skip to content

Bugfix/return type wrong type hint in polygon list#329

Merged
Brunner246 merged 3 commits intomainfrom
bugfix/return-type-wrong-type-hint-in-polygon-list
Feb 23, 2026
Merged

Bugfix/return type wrong type hint in polygon list#329
Brunner246 merged 3 commits intomainfrom
bugfix/return-type-wrong-type-hint-in-polygon-list

Conversation

@Brunner246
Copy link
Contributor

polygon_list.at(idx) returns a vertex_list object and not a point_3d

Signed-off-by: Michael Brunner <brunner@cadwork.swiss>
Signed-off-by: Michael Brunner <brunner@cadwork.swiss>
@Brunner246 Brunner246 requested a review from 9and3 February 20, 2026 14:54
@Brunner246 Brunner246 requested a review from jspaquet as a code owner February 20, 2026 14:54
@Brunner246 Brunner246 added the bug Something isn't working label Feb 20, 2026
Copy link
Contributor

@9and3 9and3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! (just added extra docstring)

@Brunner246 Brunner246 merged commit b4436c4 into main Feb 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants