Skip to content

Update Pull Request Template#100

Open
cwisniew wants to merge 63 commits intodevelopfrom
pr-template-updates
Open

Update Pull Request Template#100
cwisniew wants to merge 63 commits intodevelopfrom
pr-template-updates

Conversation

@cwisniew
Copy link
Copy Markdown
Owner

@cwisniew cwisniew commented Jul 6, 2025

Requirements for Contributing a Bug Fix or Enhancement

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in timely manner will result in a request for you to update the pull request
    and possibly closure of the pull request if it is not provided after this request.
  • After you create the pull request, all status checks must pass before a maintainer will review your contribution.

Identify the Bug or Feature request

Description of the Change

Possible Drawbacks

Documentation Notes

Release Notes

Baaaaaz and others added 30 commits June 26, 2025 23:01
Added tooltips to column headers.
Implemented them.
Attached relevant keys for nearly all preferences.
Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.7-3 to 1.5.7-4.
- [Commits](luben/zstd-jni@v1.5.7-3...v1.5.7-4)

---
updated-dependencies:
- dependency-name: com.github.luben:zstd-jni
  dependency-version: 1.5.7-4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dev.onvoid.webrtc:webrtc-java](https://github.com/devopvoid/webrtc-java) from 0.10.0 to 0.11.0.
- [Release notes](https://github.com/devopvoid/webrtc-java/releases)
- [Changelog](https://github.com/devopvoid/webrtc-java/blob/master/CHANGELOG.md)
- [Commits](devopvoid/webrtc-java@v0.10.0...v0.11.0)

---
updated-dependencies:
- dependency-name: dev.onvoid.webrtc:webrtc-java
  dependency-version: 0.11.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Integrated label and tooltip strings with preferences.
…drawpanel-icons-from-Rods-iconset

Add some erase icons for drawings, and get DrawPanel to use new icons
…sort-order-improvements

Enchanced Token Initiative sorting.
Migrate CampaignProperties dialog to GenericDialog
Bumps com.diffplug.spotless from 7.0.4 to 7.1.0.

---
updated-dependencies:
- dependency-name: com.diffplug.spotless
  dependency-version: 7.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…server-dialog

Make the Connect to Server dialog modal
Bumps [org.apache.tika:tika-core](https://github.com/apache/tika) from 3.2.0 to 3.2.1.
- [Changelog](https://github.com/apache/tika/blob/main/CHANGES.txt)
- [Commits](https://github.com/apache/tika/commits/3.2.1)

---
updated-dependencies:
- dependency-name: org.apache.tika:tika-core
  dependency-version: 3.2.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-lang3
  dependency-version: 3.18.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
No longer are they loaded from an XML file, yielding the following benefits:
- No more sensitivity to XStream configuration
- No more coupling LightSource to XStream
- Easier to find, update, understand default light sources
This was more involved than it seemed it should be:
- The TokenFootprintCreator was out of date and did not have entries for all footprints. Had to add these manually.
- Footprints must accept a GUID so that it can be stable across campaign saves. Previously, this could only be
  accomplished via XStream setting the `id` field during loading, but code had no way of doing the same.
- Similar story for translations, it relied on a flag that could only be set via XML. This one is actually worse, since
  Java could well do constant folding and ignore our translations if it felt like it. Now constructors take an explicit
  `localizedName` parameter, and the footprint has a transient `localizedName` field that is also present in the DTO.
  TODO What is the raw name even used for? Could we get rid of it?

TokenFootprint was also due for a bit of cleanup, e.g., making the public default constructor (which _is_ used in one
place) actually initialize the object.
Need to use the new `PreferenceDialog#showDialog()` instead of the old `PreferenceDialog#setVisible(boolean)`.
…p/org.apache.commons-commons-lang3-3.18.0

Bump org.apache.commons:commons-lang3 from 3.17.0 to 3.18.0
…p/com.diffplug.spotless-7.1.0

Bump com.diffplug.spotless from 7.0.4 to 7.1.0
…p/org.apache.tika-tika-core-3.2.1

Bump org.apache.tika:tika-core from 3.2.0 to 3.2.1
…p/dev.onvoid.webrtc-webrtc-java-0.11.0

Bump dev.onvoid.webrtc:webrtc-java from 0.10.0 to 0.11.0
kwvanderlinde and others added 30 commits July 11, 2025 15:19
This restores behaviour from 1.15.2 and earlier, and allows the user to see the shape they are drawing when using a
transparent outline (foreground).
…lack-border-when-drawing-linear-tools

For linear drawing tools, force the foreground mode to be solid
…ve-xml-model-definitions

Remove XML for light sources and token footprints
Bumps `flatlaf` from 3.6 to 3.6.1.

Updates `com.formdev:flatlaf` from 3.6 to 3.6.1
- [Release notes](https://github.com/JFormDesigner/FlatLaf/releases)
- [Changelog](https://github.com/JFormDesigner/FlatLaf/blob/main/CHANGELOG.md)
- [Commits](JFormDesigner/FlatLaf@3.6...3.6.1)

Updates `com.formdev:flatlaf-intellij-themes` from 3.6 to 3.6.1
- [Release notes](https://github.com/JFormDesigner/FlatLaf/releases)
- [Changelog](https://github.com/JFormDesigner/FlatLaf/blob/main/CHANGELOG.md)
- [Commits](JFormDesigner/FlatLaf@3.6...3.6.1)

Updates `com.formdev:flatlaf-extras` from 3.6 to 3.6.1
- [Release notes](https://github.com/JFormDesigner/FlatLaf/releases)
- [Changelog](https://github.com/JFormDesigner/FlatLaf/blob/main/CHANGELOG.md)
- [Commits](JFormDesigner/FlatLaf@3.6...3.6.1)

Updates `com.formdev:flatlaf-jide-oss` from 3.6 to 3.6.1
- [Release notes](https://github.com/JFormDesigner/FlatLaf/releases)
- [Changelog](https://github.com/JFormDesigner/FlatLaf/blob/main/CHANGELOG.md)
- [Commits](JFormDesigner/FlatLaf@3.6...3.6.1)

---
updated-dependencies:
- dependency-name: com.formdev:flatlaf
  dependency-version: 3.6.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: com.formdev:flatlaf-intellij-themes
  dependency-version: 3.6.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: com.formdev:flatlaf-extras
  dependency-version: 3.6.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: com.formdev:flatlaf-jide-oss
  dependency-version: 3.6.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps `log4j` from 2.25.0 to 2.25.1.

Updates `org.apache.logging.log4j:log4j-core` from 2.25.0 to 2.25.1

Updates `org.apache.logging.log4j:log4j-api` from 2.25.0 to 2.25.1

Updates `org.apache.logging.log4j:log4j-jul` from 2.25.0 to 2.25.1

Updates `org.apache.logging.log4j:log4j-1.2-api` from 2.25.0 to 2.25.1

---
updated-dependencies:
- dependency-name: org.apache.logging.log4j:log4j-core
  dependency-version: 2.25.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.logging.log4j:log4j-api
  dependency-version: 2.25.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.logging.log4j:log4j-jul
  dependency-version: 2.25.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: org.apache.logging.log4j:log4j-1.2-api
  dependency-version: 2.25.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
This probably fixes a bug somewhere as well, since it was not valid to calculate ZonePoint differences by simply adding
some number of cell dimensions since hex grids are not like square grids.
This lets FileUtil be more generic rather than supporting MT directly.
Also plumb it around as method parameters instead of having ImageUtil and ThumbnailManager look it up directly from
AppPreferences. This makes the callers a bit more ugly, but allows ImageUtil to be used outside of MT-specific code.
…sing AppPreference

This breaks a dependency of ImageTransferableHelper on application state. The result is a bit ugly, but quite functional
especially given the interface we have to work with.
- Syrinscape URL connection and handler
- CollectionUtil
- StringUtil
- CipherUtil and PublicPrivateKeyStore

PublicPrivateKeyStore has also been changed so the file paths are injected. This makes the class agnostic of application
state.
And enforce naming standards (FLIP_DIRECTION -> FlipDirection)
Move a bunch of generic libraries from net.rptools.lib into this project. Not everything could be moved over
immediately, though.
…ndency-breaking

Factor common utilities into a separate subproject
…p/log4j-2.25.1

Bump log4j from 2.25.0 to 2.25.1
…p/flatlaf-3.6.1

Bump flatlaf from 3.6 to 3.6.1
…popup-menu-set-properties-on-all-selected

Set properties of selected drawn elements
This breaks a key dependency from dicelib on the `MapTool` god object and the MapTool model. And the new
`ExpressionParserFactory` now hides the complexity around creating an `ExpressionParser`.
All dicelib code is now in this subproject to make sure it doesn't pick up unwarranted dependencies on MT itself.
…obuf

Move protobuf messages into a separate subproject
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants