Skip to content

change name of question icon to fix bug in helper#27

Open
lmsimp wants to merge 1 commit intocwthom:masterfrom
lmsimp:fix_helper
Open

change name of question icon to fix bug in helper#27
lmsimp wants to merge 1 commit intocwthom:masterfrom
lmsimp:fix_helper

Conversation

@lmsimp
Copy link
Copy Markdown

@lmsimp lmsimp commented Oct 5, 2022

Hello, I have been using shinyhelper for my apps and have noticed that the icon for question mark has changed name from from question-circle to circle-question.

I was previously getting this warning when running my app

This Font Awesome icon ('question-circle') does not exist:
* if providing a custom `html_dependency` these `name` checks can 
  be deactivated with `verify_fa = FALSE

This is fixed in this PR.

I have not bumped the package version in DESCRIPTION or NEWS as I was unsure of your versioning system but did update the documentation with roxygen2.

> sessionInfo()
R version 4.2.0 (2022-04-22)
Platform: x86_64-apple-darwin17.0 (64-bit)
Running under: macOS Monterey 12.4

Matrix products: default
LAPACK: /Library/Frameworks/R.framework/Versions/4.2/Resources/lib/libRlapack.dylib

locale:
[1] en_GB.UTF-8/en_GB.UTF-8/en_GB.UTF-8/C/en_GB.UTF-8/en_GB.UTF-8

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
 [1] shinydashboardPlus_2.0.3 shinydashboard_0.7.2     FNN_1.1.3.1             
 [4] shinyjs_2.1.0            shinyWidgets_0.7.3       dendextend_1.16.0       
 [7] tidyr_1.2.1              patchwork_1.1.2          ggplot2_3.3.6           
[10] colorspace_2.0-3         colourpicker_1.1.1       shinythemes_1.2.0       
[13] DT_0.25                  shiny_1.7.2              dplyr_1.0.10            
[16] shinyhelper_0.3.2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant