Open
Conversation
added 4 commits
November 2, 2016 11:14
* Tests for analysed modules collection initialize. * Tests for the where method in analysed collection module
* Documenting how to integrate with jenkins. * Checking if the gitlab configuration and jenkins threshold are set.
Editing Description,Summary in rubycritic_extension.gemspec
tejasbubane
reviewed
Nov 10, 2016
| Alternatively if you're using GitLab you can pass `pull_request_id` as the third argument which will post a comment to the respective pull_request: | ||
|
|
||
| ```bash | ||
| $ rubycritic_extension -b base_branch,feature_branch,pull_request_id |
There was a problem hiding this comment.
parameters should be space separated not comma separated (like unix commands)
eg.
rubycritic-ext -b base_branch feature_branch -p pull_request_id
There was a problem hiding this comment.
On second thought -b and -p can be optional, since we can assume the extension does only two things -
- runs rubycritic on two branches - hence first 2 args are branch names
- optionally posts to PR - hence third arg optional pull_request_id
tejasbubane
reviewed
Nov 10, 2016
|
|
||
| For posting comment on a pull_request in GitLab below are the configuration. Create a file in config directory `rubycritic_app_settings.yml` with following details | ||
|
|
||
| ```ruby |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.