Skip to content

Feature/#30 allow only logged in users to read user data#100

Open
reinierl wants to merge 3 commits intomainfrom
feature/#30-allow-only-logged-in-users-to-read-user-data
Open

Feature/#30 allow only logged in users to read user data#100
reinierl wants to merge 3 commits intomainfrom
feature/#30-allow-only-logged-in-users-to-read-user-data

Conversation

@reinierl
Copy link
Collaborator

@reinierl reinierl commented Nov 7, 2021

This should fix #30 by setting the appropriate security rules, and hiding functionality that uses other people's data from non logged in people.

@bidsinga
Copy link
Collaborator

Guess if we only allow logged in users to enter the map, we should also change this is layouts/Footer.vue. Wouldn't it be better to allow logged out users to at least access the POI's and country pages, and to hide the user markers in the map?

@reinierl
Copy link
Collaborator Author

Logged out users can still go to the map if they really really want to and type the URL directly at this point. I just removed the navigation so they don't go there only to be disappointed by the things that don't work.

What would you say if I created a follow-up issue for reinstating the map for logged out users? And then we should also make sure that we take care to give them a decent experience.

@reinierl
Copy link
Collaborator Author

@bidsinga I've created the follow-up issue: #107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow only logged-in users to read profile data of potential hosts

2 participants