Feature/#30 allow only logged in users to read user data#100
Open
Feature/#30 allow only logged in users to read user data#100
Conversation
Collaborator
|
Guess if we only allow logged in users to enter the map, we should also change this is |
Collaborator
Author
|
Logged out users can still go to the map if they really really want to and type the URL directly at this point. I just removed the navigation so they don't go there only to be disappointed by the things that don't work. What would you say if I created a follow-up issue for reinstating the map for logged out users? And then we should also make sure that we take care to give them a decent experience. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #30 by setting the appropriate security rules, and hiding functionality that uses other people's data from non logged in people.