Fix Digural API URL not updating without app restart #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DiguralApi singleton was using lazy initialization for the Retrofit instance, which meant it was only created once with the initial baseUrl. When users changed the URL in settings, the new URL was stored but the cached Retrofit instance continued using the old URL until app restart. Changes: - Convert baseUrl from lateinit var to custom property with getter/setter - Add invalidation logic that clears cached Retrofit instances when URL changes - Replace lazy initialization with nullable backing fields that recreate on demand - Add debug logging when baseUrl changes to aid troubleshooting This ensures the new URL takes effect immediately when changed in settings, whether during an active capture session or between sessions.
hb0
force-pushed
the
task/LEIP-410_fix-digural-url-only-updated-after-app-restart
branch
from
8674bfe to
7e9f654
Compare
hb0
deleted the
task/LEIP-410_fix-digural-url-only-updated-after-app-restart
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DiguralApi singleton was using lazy initialization for the Retrofit instance, which meant it was only created once with the initial baseUrl. When users changed the URL in settings, the new URL was stored but the cached Retrofit instance continued using the old URL until app restart.
Changes:
This ensures the new URL takes effect immediately when changed in settings, whether during an active capture session or between sessions.