[LEIP-409] Add StorageHelper with fallback to internal storage #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creates a new StorageHelper utility class that provides robust storage selection with fallback logic. The helper tries primary external storage first (checking if it's mounted and writable), then falls back to internal storage if external is unavailable. This replaces the previous approach where external storage was required and would throw exceptions if unavailable. The new approach ensures the app can always find a suitable storage location. Changes: - Add StorageHelper.getStorageDirectoryWithFallback() for File objects - Add StorageHelper.getStoragePathWithFallback() for String paths - Update DiskConsumption to use StorageHelper (requires Context parameter) - Remove Constants.externalCyfaceFolderPath() (replaced by StorageHelper) - Only uses primary external storage, avoiding removable media
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a new StorageHelper utility class that provides robust storage selection with fallback logic. The helper tries primary external storage first (checking if it's mounted and writable), then falls back to internal storage if external is unavailable.
This replaces the previous approach where external storage was required and would throw exceptions if unavailable. The new approach ensures the app can always find a suitable storage location.
Changes: