Add support for PHP 8.3 & 8.4. #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension was already working in these versions but now they are part of the CI workflow.
kevindecapite
commented
Apr 18, 2025
Collaborator
Author
kevindecapite
left a comment
kevindecapite
left a comment
There was a problem hiding this comment.
Since this extension doesn't introduce new behavior to the Swiss Ephemeris API, I think all tests should eventually be rewritten to assert on types only which proves the extension is properly interfacing with the SE library.
The value tests of the methods are already handled in the SE library itself anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release as new minor version 4.0.11.